Skip to content

Keep injected redacted_compat.h file out of the windows python's build inputs - #54783

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
alopez/python-windows-build-remove-compat-h
Aug 12, 2026
Merged

Keep injected redacted_compat.h file out of the windows python's build inputs#54783
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
alopez/python-windows-build-remove-compat-h

Conversation

@alopezz

@alopezz alopezz commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

It removes the redacted_compat.h file out of the sources for the Python build on Windows, such that it doesn't get used for cache computation.

Motivation

I didn't get remote cache hits on a local checkout with git core.autocrlf disabled (see also #54776) due to this specific file. Since the file is only intended for the configure_make rule that builds Python on Linux / macOS, we can simply remove the file from inputs to mitigate the problem (regardless of whether we go with #54776 or any other similar more general solution).

Describe how you validated your changes

CI.

Additional Notes

Due to the lack of windows sandboxing, the excluded sources for the rule are actually visible to the build action, so there's no guarantee that it doesn't get used by it. However, given that it's a file that we introduce ourselves and not looked at by Python's build system, it's fairly safe to assume that in practice this file doesn't cause any difference to the build outputs.

@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-build labels Aug 12, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Aug 12, 2026
@alopezz alopezz changed the title Keep injected redacted_compat.h file out of the window python's build inputs Keep injected redacted_compat.h file out of the windows python's build inputs Aug 12, 2026
@alopezz alopezz added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Aug 12, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 3dda73e9:

Results for datadog-agent_7.84.0~devel.git.140.273b7f0.pipeline.130487601-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.140.273b7f0.pipeline.130487601-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 3dda73e
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_deb_amd64 759.819 MiB
✅ agent_deb_amd64_fips 712.684 MiB
✅ agent_heroku_amd64 312.388 MiB
✅ agent_msi 643.504 MiB
✅ agent_rpm_amd64 759.803 MiB
✅ agent_rpm_amd64_fips 712.667 MiB
✅ agent_rpm_arm64 735.704 MiB
✅ agent_rpm_arm64_fips 691.894 MiB
✅ agent_suse_amd64 759.803 MiB
✅ agent_suse_amd64_fips 712.667 MiB
✅ agent_suse_arm64 735.704 MiB
✅ agent_suse_arm64_fips 691.894 MiB
✅ docker_agent_amd64 818.431 MiB
✅ docker_agent_arm64 819.379 MiB
✅ docker_agent_jmx_amd64 1009.328 MiB
✅ docker_agent_jmx_arm64 998.929 MiB
✅ docker_cluster_agent_amd64 210.475 MiB
✅ docker_cluster_agent_arm64 223.455 MiB
✅ docker_cws_instrumentation_amd64 7.439 MiB
✅ docker_cws_instrumentation_arm64 6.877 MiB
✅ docker_dogstatsd_amd64 39.482 MiB
✅ docker_dogstatsd_arm64 37.560 MiB
✅ docker_host_profiler_amd64 305.816 MiB
✅ docker_host_profiler_arm64 317.125 MiB
✅ dogstatsd_deb_amd64 30.224 MiB
✅ dogstatsd_deb_arm64 28.247 MiB
✅ dogstatsd_rpm_amd64 30.224 MiB
✅ dogstatsd_suse_amd64 30.224 MiB
✅ iot_agent_deb_amd64 46.444 MiB
✅ iot_agent_deb_arm64 43.100 MiB
✅ iot_agent_deb_armhf 43.883 MiB
✅ iot_agent_rpm_amd64 46.444 MiB
✅ iot_agent_suse_amd64 46.443 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7c554e1b-e401-4a4a-873b-cd4c2ac17957

Baseline: e239027
Comparison: 645110a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +0.63 [-0.23, +1.49] 1 Logs bounds checks dashboard
➖ quality_gate_security_no_fs_load memory utilization +0.27 [+0.12, +0.42] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization +0.12 [+0.08, +0.16] 1 Logs bounds checks dashboard
➖ quality_gate_security_mean_fs_load memory utilization +0.02 [-0.05, +0.09] 1 Logs bounds checks dashboard
➖ quality_gate_security_idle memory utilization -0.10 [-0.21, +0.01] 1 Logs bounds checks dashboard
➖ quality_gate_private_action_runner memory utilization -0.14 [-0.26, -0.02] 1 Logs bounds checks dashboard
➖ quality_gate_idle memory utilization -0.20 [-0.32, -0.08] 1 Logs bounds checks dashboard
➖ quality_gate_metrics_logs memory utilization -0.34 [-0.58, -0.09] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed observed_value links
✅ quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
❌ quality_gate_idle memory_usage 0/10 172.56MiB > 154MiB bounds checks dashboard
✅ quality_gate_idle total_bytes_received 10/10 728.47KiB ≤ 819.20KiB bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 511.02MiB ≤ 512MiB bounds checks dashboard
✅ quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 17 ≤ 40 bounds checks dashboard
❌ quality_gate_logs memory_usage 1/10 206.24MiB > 195MiB bounds checks dashboard
✅ quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_logs total_bytes_received 10/10 264.16MiB ≤ 292MiB bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 402.24 ≤ 2000 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 19 ≤ 40 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 392.48MiB ≤ 430MiB bounds checks dashboard
✅ quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
✅ quality_gate_private_action_runner memory_usage 10/10 72.41MiB ≤ 75MiB bounds checks dashboard
✅ quality_gate_security_idle cpu_usage 10/10 31.67 ≤ 100 bounds checks dashboard
✅ quality_gate_security_idle memory_usage 10/10 324.89MiB ≤ 330MiB bounds checks dashboard
✅ quality_gate_security_mean_fs_load cpu_usage 10/10 67.45 ≤ 200 bounds checks dashboard
✅ quality_gate_security_mean_fs_load memory_usage 10/10 306.62MiB ≤ 310MiB bounds checks dashboard
✅ quality_gate_security_no_fs_load cpu_usage 10/10 24.17 ≤ 100 bounds checks dashboard
✅ quality_gate_security_no_fs_load memory_usage 10/10 315.89MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_idle comparison 10 Oom killed Debug Dashboard
quality_gate_security_mean_fs_load baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_no_fs_load baseline 10 Oom killed Debug Dashboard
quality_gate_security_no_fs_load comparison 10 Crashed (exit code: 134) Debug Dashboard

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 1/10 replicas passed. Failed 9 which is > 0. Gate FAILED.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@alopezz
alopezz marked this pull request as ready for review August 12, 2026 15:57
@alopezz
alopezz requested a review from a team as a code owner August 12, 2026 15:57
@github-actions github-actions Bot deleted a comment from chatgpt-codex-connector Bot Aug 12, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 645110a into main Aug 12, 2026
321 of 333 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the alopez/python-windows-build-remove-compat-h branch August 12, 2026 17:40
@github-actions github-actions Bot added this to the 7.84.0 milestone Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdesgroppes rdesgroppes rdesgroppes approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build

Projects

None yet

Milestone

7.84.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alopezz @rdesgroppes